feat(clerk-js): Accept skipInvitationScreen as a prop from OrganizationSwitcher#2713
Merged
panteliselef merged 2 commits intomainfrom Feb 5, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 23aad67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikosdouvlis
approved these changes
Feb 5, 2024
| * @default undefined When left undefined Clerk will automatically hide the screen if | ||
| * the number of max allowed members is equal to 1 | ||
| */ | ||
| skipInvitationScreen?: boolean; |
Member
There was a problem hiding this comment.
Why don't we nest this under createOrganizationProps?
Contributor
Author
There was a problem hiding this comment.
As i mention in the description, I'd like to backport this to v4 as is, in order to follow the same pattern.
I can come back and update the grouping of props for both OrgnanizationSwitcher and OrganizationList only for v5.
24 tasks
panteliselef
added a commit
that referenced
this pull request
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
skipInvitationScreenshould be something that affects the flow of creating an organization.<CreateOrganization/>and<OrganizationList/>already handles this correctly. This PR adds this functionality to<OrganizationSwitcher/>as well.This implementation is compatible with v4 and does not introduce breaking changes and will be backported.
Grouping
skipInvitationScreenandafterCreateOrganizationUrlundercreateOrganizationPropscould be part of a followup PR only for v5.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore